Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename "complete-task" to "start-worker" #17

Open
pihme opened this issue Sep 29, 2020 · 2 comments
Open

Rename "complete-task" to "start-worker" #17

pihme opened this issue Sep 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@pihme
Copy link
Contributor

pihme commented Sep 29, 2020

Is your feature request related to a problem? Please describe.
The action "complete-task" is misleading. It sounds as if I could complete a single activated job. However, what is actually happening is that a worker is started which is waiting for jobs to get activated and then completing all of them.

Describe the solution you'd like
I would like to have a name that is clear.

@pihme pihme added the enhancement New feature or request label Sep 29, 2020
@pihme
Copy link
Contributor Author

pihme commented Sep 29, 2020

I'm happy to make the change. I just wanted to create the issue as a reminder, so we can talk about and decide whether this shall be changed or not.

@saig0
Copy link
Collaborator

saig0 commented Sep 30, 2020

I'm supporting the intention of having clear names. When we talk about Zeebe then it would be more exact to call it "start-worker".

But I'm not sure about changing the name because the tool should be agnostic to the concrete BPMN engine. Another engine may call it differently. The name "complete-task" is more general. So, the concrete test runner can implement it in a proper way.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants