Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use time.Duration instead of int #43

Open
gorsuch opened this issue May 17, 2015 · 1 comment
Open

use time.Duration instead of int #43

gorsuch opened this issue May 17, 2015 · 1 comment

Comments

@gorsuch
Copy link
Member

gorsuch commented May 17, 2015

While working on #42 I came across several instances where we're using int data types when we should just be using time.Duration. This makes things harder to reason about, as you have to continually ask "is this time in milliseconds? seconds?", etc.

Unifying these values around time.Duration would be a big win.

@blalor
Copy link
Contributor

blalor commented Jun 8, 2015

+1

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants