Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SQL on_error defaults to Commit #326

Closed
jsoverson opened this issue Jun 23, 2023 · 1 comment
Closed

SQL on_error defaults to Commit #326

jsoverson opened this issue Jun 23, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jsoverson
Copy link
Contributor

Describe the bug
The on_error behavior for sql components defaults to commit due to how codegen sets defaults.

Additional context
Caught during troubleshooting a swallowed error.
@jsoverson jsoverson added the bug Something isn't working label Jun 23, 2023
@jsoverson jsoverson mentioned this issue Jun 23, 2023
Merged
@jsoverson
Copy link
Contributor Author

Closed via #325

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsoverson