Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Config rendering errors at the operation level can get swallowed by filter rules. #333

Closed
jsoverson opened this issue Jun 27, 2023 · 1 comment
Labels
bug Something isn't working triage To be triaged

Comments

@jsoverson
Copy link
Contributor

Describe the bug
Configuration failures for operation instances at the operation level don't get exposed to the user.

Expected behavior

If I have a busted config, I expect an error like everywhere else:

2023-06-27T15:00:36 ERROR interpreter:event_loop:event_loop:event{otel.name="tx_start" i=0 tx_id=7f6f2ccd-b23f-2abb-7b69-278e947c01c6}: tx_error=Component error: Could not render operation configuration: liquid: Unknown index
  with:
    variable=ctx.root_config
    requested index=token
    available indexes=

Actual behavior

No error, no warning, execution just continues as normal.

Environment:

  • OS: mac
  • Architecture: m1
  • Build Version: HEAD
@jsoverson jsoverson added bug Something isn't working triage To be triaged labels Jun 27, 2023
@jsoverson
Copy link
Contributor Author

Fixed via #335

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working triage To be triaged
Projects
None yet
Development

No branches or pull requests

1 participant