Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ONBOARDING] valkey #305

Open
12 of 13 tasks
reneradoi opened this issue Dec 6, 2024 · 5 comments
Open
12 of 13 tasks

[ONBOARDING] valkey #305

reneradoi opened this issue Dec 6, 2024 · 5 comments
Assignees
Labels
onboarding Issues related to image onboarding requests

Comments

@reneradoi
Copy link

reneradoi commented Dec 6, 2024

Image name

valkey

Short description

Valkey Rock Image based on Ubuntu. Valkey is a flexible distributed key-value datastore that is optimized for caching and other realtime workloads. This image bundles Valkey together with the metrics exporter.

Image repository

https://github.com/canonical/charmed-valkey-rock

Maintainer agreement

  • I agree to follow this project's Code of Conduct

  • I understand and acknowledge the CONTRIBUTING guidelines and Image Maintainer Agreement

  • This image is a rock which already exists in the 'ubuntu' namespace

  • I agree to be the image's Maintainer and thus own it and be responsible for it, thus committing to maintaining it throughout its lifetime

  • My image's repository (where the build recipes are hosted) is public

  • I agree to have the provided contacts added to the Image Maintainers mailing list in Launchpad

  • This image is meant to be published to the 'ubuntu' namespace, and thus a new registry repository should be created

  • I acknowledge that this image shall be monitored by the security team and that I've made the necessary modifications
    to support that

  • I commit to address image issues in a timely manner and according to their severity

  • I will always provide up-to-date documentation for this image

  • I understand the OCI tagging convention

  • I understand the image's stability commitments

  • I will test my image before proposing new build and releases

Security enablement

Primary contact

data-platform@lists.launchpad.net

Backup contact

No response

@reneradoi reneradoi added the onboarding Issues related to image onboarding requests label Dec 6, 2024
@reneradoi reneradoi changed the title [ONBOARDING] [ONBOARDING] valkey Dec 6, 2024
@cjdcordeiro
Copy link
Collaborator

Nice! Thanks @reneradoi .

  • The name of the rock should be valkey, and not valkey-rock, right? As for the description, is that what you'd like to have as a description in the registries? The other images we have follow a slightly different approach. Please check some of them in https://hub.docker.com/r/ubuntu/

  • data-platform@lists.launchpad.net is already a member of the LP team, so that's good.

  • are you also including the manifest.yaml alongside the snapcraft.yaml? And did you reach out to the security team by email to notify them of this new image to be monitored?

Blocks #306

@reneradoi
Copy link
Author

Hey @cjdcordeiro , thank you for the feedback.

I've updated the image name and description to follow the ones already available. Hope you agree with that.

As for the security enablement:

  • There is no manifest.yaml in the snap, that's why I didn't include it here.
  • I did not yet reach out to the security team by email, I only followed the required steps in the Image Maintainer Agreement (btw. there is no email address mentioned in the checklist)

Please let me know whom to contact or what else to provide.

Thank you!

@cjdcordeiro
Copy link
Collaborator

Thanks for the changes @reneradoi .

I did not yet reach out to the security team by email, I only followed the required steps in the Image Maintainer Agreement (btw. there is no email address mentioned in the checklist)

Right. It's on this issue's template: https://github.com/canonical/oci-factory/blob/main/.github/ISSUE_TEMPLATE/--onboarding.yaml?plain=1#L96

@reneradoi
Copy link
Author

Message to security team has been sent.

@cjdcordeiro
Copy link
Collaborator

Repos created. Waiting for reply from security team to close the issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
onboarding Issues related to image onboarding requests
Projects
None yet
Development

No branches or pull requests

2 participants