Waterfall multiple callback defense #1050
Merged
+167
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return rest(function(err, args) { | ||
| function nextTask(args) { | ||
| if (taskIndex === tasks.length) { | ||
| return cb.apply(null, [null].concat(args)); |
There was a problem hiding this comment.
It's being transpiled so you can do cb(null, ...args)
aearly
added a commit
that referenced
this pull request
Mar 8, 2016
Waterfall multiple callback defense
|
:( I just noticed that |
|
Ah, lets not do that for now in that case |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #815 .
This introduces a breaking change -- previously multiple callbacks would call the rest of the waterfall multiple times, now calling a callback multiple times is an error.
This also fixes a detail related to #696 -- no unnecessary deferrals in waterfall.