Removing internal setImmediate's #704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ```js | ||
| async.eachSeries(hugeArray, function iterator(item, callback) { | ||
| if (item.somePredicate()) { |
There was a problem hiding this comment.
In order to match the example above, I think this should be changed to:
if (matchesSomething(item)) {
|
Closing this for now. The doc updates were already added. Things have diverged so much this PR isn't useful -- we'll track this with #696 for v2.0. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in #696 , this PR removes most internal
setImmediatesto remove the unnecessary performance hit when you're using asynchronous functions. It leaves it to the user to guard against stack overflows withasync.setImmediateorasync.nextTickif they need to callback synchronously. This is a breaking change since there are many people relying on automatic deferral inwaterfallandauto.I had to refactor the logic in the functions that used
setImmediatebecause the internal logic was relying on those deferrals. The timing of certain callbacks and events has also changed, so there will be further subtle breaking changes there. If the functions you pass to async were actually asynchronous, things should work as they always have.I left the deferrals in for
priorityQueueandcargo, because those seemed to be needed for them to actually work. They need to defer in order to become saturated so the priorities and payload sizes can take effect.I also see that
queue,priorityQueue, andcargocould likely be refactored to use the same underlying logic, albeit a bit more complicated.queuewould have a payload size as well as a concurrency, andq.pushwould have an optional priority parameter.