Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing href prop in ClickableTile #253

Closed
albertms10 opened this issue Sep 15, 2020 · 1 comment · Fixed by #254
Closed

Missing href prop in ClickableTile #253

albertms10 opened this issue Sep 15, 2020 · 1 comment · Fixed by #254
Assignees
@metonym
Labels
bug Something isn't working severe Blocking issue

Comments

@albertms10
Copy link
Contributor

albertms10 commented Sep 15, 2020 •
edited
Loading

The ClickableTile component should define an href prop, as it uses it to add a link to the DOM element.

TypeScript warns about it:

Type '{ href: string; }' is not assignable to type 'IntrinsicAttributes & { clicked?: boolean; light?: boolean; }'.
  Property 'href' does not exist on type 'IntrinsicAttributes & { clicked?: boolean; light?: boolean; }'. ts(2322)
@metonym metonym added bug Something isn't working severe Blocking issue labels Sep 15, 2020
@metonym metonym self-assigned this Sep 15, 2020
@josefaidt josefaidt mentioned this issue Sep 16, 2020
Merged
@metonym
Copy link
Collaborator

metonym commented Sep 16, 2020

Patched in v0.12.3

@metonym metonym mentioned this issue Oct 6, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@metonym metonym

Labels
bug Something isn't working severe Blocking issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tile): add href prop
2 participants
@metonym @albertms10