Incorrect url generated for fog storage + aws

[ransombriggs]

We are in the process of moving to carrierwave but have found an issue in url generation & fog when the bucket has a period in it like foo.bar. The problem is that carrierwave detects as a valid subdomain where as fog does not. I tested using the https://foo.bar.s3.amazonaws.com/ style url that carrierwave constructs but when I request it I get a certificate error because of the multiple nestings of domains causing the cert to not match.

curl: (51) SSL: certificate subject name (*.s3.amazonaws.com) does not match target host name 'foo.bar.s3.amazonaws.com'

I can file a pull request for this and fix in either one of two ways, either I could add the extra condition like fog does, or I could add a fog option to force the generation to pass to fog. Let me know what you think and I can put something together.

[ransombriggs]

I wrote a monkey patch in my project to get this working and I think the better way would be to add the extra conditional to avoid the extra network calls, will work on a PR next week.

[ransombriggs]

I finished our transition to carrierwave so I went ahead and filed a PR for this bug.

[mshibuya]

Fixed by #2359.