Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove guava #280

Merged
merged 2 commits into from
Jun 18, 2022
Merged

fix: remove guava #280

merged 2 commits into from
Jun 18, 2022

Conversation

i1619khz
Copy link
Contributor

@i1619khz i1619khz commented Jun 12, 2022

change

  • remove guava
  • replace guava's HashFunction with md5 function that only depends on jdk

test
Tests run: 126, Failures: 0, Errors: 0, Skipped: 0

Fix: #279

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


1619khz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@casbin-bot
Copy link
Member

@tangyang9464 @seriouszyx @elfisworking please review

@codecov-commenter
Copy link

Codecov Report

Merging #280 (061b1d3) into master (a21b219) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   66.38%   66.20%   -0.18%     
==========================================
  Files          45       45              
  Lines        2240     2240              
  Branches      393      393              
==========================================
- Hits         1487     1483       -4     
- Misses        635      638       +3     
- Partials      118      119       +1     
Impacted Files Coverage Δ
src/main/java/org/casbin/jcasbin/util/Util.java 63.73% <50.00%> (-4.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21b219...061b1d3. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented Jun 12, 2022

@i1619khz plz:

  1. Use fix: xxx instead of refactor: xxx for PR title and commit msg.
  2. Fix semantic-PR
  3. Fix CLA

image

@i1619khz i1619khz closed this Jun 13, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Jun 13, 2022

@i1619khz plz don't close this PR. You can do the re-work inside this PR.

@i1619khz i1619khz changed the title refactor: remove guava fix: remove guava Jun 13, 2022
@i1619khz i1619khz reopened this Jun 13, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Jun 18, 2022

@tangyang9464 plz review

@tangyang9464
Copy link
Member

@i1619khz plz suqash your commits to fix semantic pr errror

@hsluoyz hsluoyz merged commit e777aec into casbin:master Jun 18, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove guava
6 participants