Unable to handle model properties that contain dots (.)
#362
Comments
|
Hi @checketts, thanks for reporting and, ooof, this is wild. I'm not a Spring user, but modifying Spring keys to match jte parameter name syntax is asking for trouble. For instance, once Spring starts having keys with underscores that might collide with the hacked keys. I'm not sure, but maybe there could be other ways to access those things into the jte templates? Input from real Spring - jte users would be very welcome here :-) |
|
The way I've worked around it in my code is to create a For JTE, when populating a For example (in a Then if there is a key with underscores that would match, it would be used first, and if not, then check for a key with periods? |
|
No, I would rather not introduce this kind of magic to jte. It will add a performance overhead for every template invocation through maps. It also obfuscates constants (e.g. in your example a project wide search will not find Adding a utility method to the spring lib sounds like a much better API for this problem. |
|
Hi @checketts, did you get around to iterating on the |
|
I'll try to release a sample project shortly. My current solution has worked well, but feels quite hacky. (Since it was influenced by the Thymeleaf pattern to aid in migration) I use a custom class MyJteView(
private val templateEngine: TemplateEngine,
private val messageSource: MessageSource,
private val isDevelopmentMode: Boolean
) :
AbstractTemplateView() {
override fun checkResource(locale: Locale): Boolean {
return try {
if (isDevelopmentMode) {
true //In development mode new templates may get added dynamically
} else {
templateEngine.hasTemplate(this.url)
}
} catch (e: Exception) {
true
}
}
@Throws(Exception::class)
override fun renderMergedTemplateModel(
model: Map<String, Any>,
request: HttpServletRequest,
response: HttpServletResponse
) {
val url = this.url
response.contentType = "text/html"
response.characterEncoding = StandardCharsets.UTF_8.name()
val output = PrintWriterOutput(response.writer)
try {
val base = model["base"] as? Base
base?.let { it.renderModel = model }
templateEngine.render(url, model, output)
} catch (e: Exception) {
// response.sendError(500);
logger.error("Error rendering template: ", e)
response.writer.println("<html><body><pre>Error rendering template:\n")
val out = PrintWriterOutput(response.writer)
Escape.htmlContent(e.localizedMessage, out)
if (e.cause != null) {
Escape.htmlContent(e.cause!!.localizedMessage, out)
}
response.writer.println("</pre></body></html>")
} finally {
// JteContext.dispose()
}
}
}Base: data class Base(
val user: UserPrincipal?,
) {
var renderModel: Map<String, Any>? = null
fun errors(key: String): BeanPropertyBindingResult? {
val errors = renderModel?.get("org.springframework.validation.BindingResult.$key") as? BeanPropertyBindingResult
return errors
}
} |
|
I too am keen to see @checketts 's ValidationHelper :) Having access to binding results is the only real thing stopping me converting my project from Thymeleaf to JTE, and maybe Spring View Components too. |
With Spring validation, when a form entry has an error Spring adds a
BindingResultto the model with the key similar toorg.springframework.validation.BindingResult.myEntry. However there isn't a way to reference the model entry via a@paramSince there are dots in the variable name that isn't allowed.
Would a PR for the Spring integration that changes the dots for underscores be welcome?
I'm looking to see if there are other options as well...
The text was updated successfully, but these errors were encountered: