Skip to content

smartCaret doesn't seem to be working #123

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
robertburczak opened this issue Apr 26, 2018 · 8 comments
Closed

smartCaret doesn't seem to be working #123

robertburczak opened this issue Apr 26, 2018 · 8 comments

Comments

@robertburczak
Copy link

Hi,

I am using this library in version 1.0.10:

"react-phone-number-input": {
      "version": "1.0.10",
      "resolved": "https://registry.npmjs.org/react-phone-number-input/-/react-phone-number-input-1.0.10.tgz",
      "integrity": "sha512-XxLkj1brNOxAebFDO/GT5GyMqrwqTONvu5XbxKf+DRLGOfaU29i0/4n4uuOVyjAdwJJNyma5c8weaD9XKeOifg==",
      "requires": {
        "classnames": "2.2.5",
        "input-format": "0.2.2",
        "libphonenumber-js": "1.1.7",
        "prop-types": "15.5.10",
        "react-lifecycles-compat": "3.0.2",
        "react-responsive-ui": "0.10.35"
      }
    },

Unfortunately when I am using smartCaret={ false }, SmartInput is still rendered. Also tried to pass input component by inputComponent={BasicInput}, but it's doesn't work either. Any suggestions?

Here's my implementation:

import Phone from 'react-phone-number-input';

<Phone
                placeholder={phonePlaceholder}
                country="PL"
                countries={['PL', 'DE']}
                smartCaret={ false }
                onChange={this.handlePhoneChange}
                value={this.state.phone}
                autoComplete="off"
                labels={{ PL: '+48', DE: '+49' }}
              />
@catamphetamine
Copy link
Owner

Why do you think "SmartInput is still rendered"?

@robertburczak
Copy link
Author

I mean, Smart Caret is working and Android bug from this issue (#75) still occurs.

@catamphetamine
Copy link
Owner

So is "SmartInput is still rendered" or not?

@robertburczak
Copy link
Author

I am not sure if I understand your question.
I have SmartInput instead of BasicInput even if I pass smartCaret={ false } and Android bug still occurs.

@catamphetamine
Copy link
Owner

I have SmartInput instead of BasicInput

What do you mean exactly by saying that?

@robertburczak
Copy link
Author

I mean that I still have an issue with Samsung Android phone and cursor doesn't keep up with typing.
Phone: Samsung Galaxy Note4
Android: v. 6.0.1
Browser: Samsung Internet v. 6.4.10.5

@catamphetamine
Copy link
Owner

catamphetamine commented Apr 26, 2018

That's a whole another thing.
I don't have a "Samsung Galaxy Note4" so I won't be able to verify or refute that.
So I'm closing this issue being a duplicate.

@catamphetamine
Copy link
Owner

Also check the demo page - if smartCaret={false} example there doesn't work on your Samsung phone then leave a comment in the Android caret bug issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@catamphetamine @robertburczak and others