Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename #define BENCHMARK or allow disabling benchmark feature #1186

Closed
mloskot opened this issue Feb 15, 2018 · 2 comments · Fixed by #1616
Closed

Rename #define BENCHMARK or allow disabling benchmark feature #1186

mloskot opened this issue Feb 15, 2018 · 2 comments · Fixed by #1616

Comments

@mloskot
Copy link
Contributor

mloskot commented Feb 15, 2018

Description

The #define BENCHMARK in a9b6813#diff-c06d59fb4f39c13fb9a355b49d321fcfR52 is an unfortunate name, with high potential of clashes.

For example, it clashes with (older) benchmarking framework, see DigitalInBlue/Celero@dc68534#diff-f1b66ca763828028068774e33319efb4R137 The generic BENCHMARK name issue also reported to Celero DigitalInBlue/Celero#114

It would be extremely helpful Catch offers a #define to allow disabling the whole benchmarking feature all the way.

@Ignition
Copy link

Ignition commented Feb 16, 2018

I may be missing something obvious, but is there a good reason why you have both Catch2 and Celero in the same translation unit?

@mloskot
Copy link
Contributor Author

mloskot commented Feb 19, 2018

It happens, there are/were some files which included both (eg. shared fixtures for both, benchmark and test, so benchmark is actually tested for correctness - in non-optimised builds)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants