Added --skip-benchmarks command-line option. #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #2408 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 157 157
Lines 7426 7430 +4
=======================================
+ Hits 6767 6771 +4
Misses 659 659 |
horenmar
requested changes
Apr 16, 2022
There was a problem hiding this comment.
This also needs tests.
It should be enough to pick some TEST_CASE that's already in the SelfTest project and has benchmarks, and then add new CTest test that invokes SelfTest with --skip-benchmarks and test spec for that one test. The test then checks that the benchmark was skipped by looking for the benchmark output.
Or add a new TEST_CASE just for this, that way is more resilient to later changes.
- Added version placeholder in documentation - Improved description of as suggested
The new CTest runs a dedicated TEST_CASE with the --skip-benchmarks option. The TEST_CASE can only succeed when the two benchmarks inside are skipped.
horenmar
reviewed
Apr 23, 2022
|
Thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature requested by #2392 "Command line option to skip benchmarks" by introducing the command-line option "--skip-benchmarks" so that Catch runs no benchmarks when this option is set. I'd be glad about feedback.