Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add trollius dependency in requirements.txt #282

Merged
merged 1 commit into from
Jan 25, 2016
Merged

Add trollius dependency in requirements.txt #282

merged 1 commit into from
Jan 25, 2016

Conversation

kartikmohta
Copy link
Contributor

I think this got added in the source recently and is missing from the requirements.txt file

@kartikmohta
Copy link
Contributor Author

It seems like there are more dependencies required right now (osrf_pycommon).

@jbohren jbohren added the bug label Jan 24, 2016
@jbohren
Copy link
Contributor

jbohren commented Jan 24, 2016

@kartikmohta Yeah, osrf_pycommon still needs to be released. See osrf/osrf_pycommon#9 if you want to help out with that.

@wjwwood
Copy link
Member

wjwwood commented Jan 25, 2016

Even still trollius is used directly by catkin tools so I think we should merge this.

It should also have osrf_pycommon, but as @jbohren pointed out, it hasn't been released yet. I'll have to do that before the next release of catkin tools since master uses it.

wjwwood added a commit that referenced this pull request Jan 25, 2016
@wjwwood
Merge pull request #282 from kartikmohta/patch-1
36f8715 
Add trollius dependency in requirements.txt
@wjwwood wjwwood merged commit 36f8715 into catkin:master Jan 25, 2016
@kartikmohta kartikmohta deleted the patch-1 branch January 25, 2016 08:28
@slivingston slivingston mentioned this pull request May 22, 2017
Closed
slivingston added a commit to slivingston/catkin_tools that referenced this pull request Jul 16, 2017
@slivingston
Add trollius to setup.py install_requires list
f7af8ff 
closes catkin#445

This patch can be viewed as continuing the work of pull request catkin#282.
@slivingston slivingston mentioned this pull request Jul 16, 2017
Merged
wjwwood pushed a commit that referenced this pull request Jul 16, 2017
@slivingston @wjwwood
Add trollius to setup.py install_requires list (#474)
fad6124 
closes #445

This patch can be viewed as continuing the work of pull request #282.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikmohta @jbohren @wjwwood