Catkin should send out only one notification #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed, that catkin sends out several notifications after a build instead of sending one summary.
This leads to a poor user experience, as you might miss some information or even get a wrong idea about the success of you build as in this example:
Build a workspace with packages that produce warnings. After the build, you will get two notifications:
This is especially confusing on system, where notifications don't stack, but really show up one after another, so that at first glance you only see half of the information.
I have therefor merged all information that is produced by the
print_compact_summary
function into a single call tonotify
, passing over all information at once.