Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SHELL environment variable handling may be unsafe #436

Open
mingless opened this issue Feb 16, 2017 · 0 comments
Open

SHELL environment variable handling may be unsafe #436

mingless opened this issue Feb 16, 2017 · 0 comments

Comments

@mingless
Copy link

Since #421 code assumes SHELL environment variable to be either empty or set shell path.
To reproduce simply run anything after setting SHELL to e.g. 'bash'.

Steps to Reproduce the Issue

export SHELL=bash
catkin build

As mentioned in #421 this assumption may or may not be safe. Moreover the error message may be misleading in this context:
RuntimeError: Cannot determine shell executable. The 'SHELL' environment variable is not set and the default 'bash' does not exist.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant