Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

delta --list-syntax-themes shows Catppuccin Latte as a dark theme #7

Closed
injust opened this issue Jul 2, 2024 · 6 comments
Closed

Comments

@injust
Copy link
Contributor

injust commented Jul 2, 2024

I can't get Catppuccin Latte to work properly as a light theme. delta --list-syntax-themes shows it as a dark theme.

I thought that #6 would fix this, but apparently not.

@injust
Copy link
Contributor Author

injust commented Jul 9, 2024

The culprit seems to be https://github.com/dandavison/delta/blob/0.17.0/src/options/theme.rs#L48. delta has a hardcoded list of themes that are considered light-mode.

The value there should be catppuccin-latte (all lowercase) instead of Catppuccin-latte.

@injust
Copy link
Contributor Author

injust commented Jul 9, 2024

Will be fixed by dandavison/delta#1745

@injust injust closed this as completed Jul 9, 2024
@injust
Copy link
Contributor Author

injust commented Jul 9, 2024

Side note: This probably wasn't a typo actually. The casing was changed at some point after dandavison/delta#1573 was opened but before the first commit in this repo.

@elbaro
Copy link

elbaro commented Aug 24, 2024

Dark syntax themes:
    1337
    Catppuccin Latte
    Coldark-Cold

This is not fixed in delta 0.18

@injust
Copy link
Contributor Author

injust commented Aug 24, 2024

Hmm, I think I made a bad PR. Should've changed it to Catppuccin Latte, not catppuccin-latte.

@injust
Copy link
Contributor Author

injust commented Aug 24, 2024

dandavison/delta#1823

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants