Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bad contrast with neogit integration #627

Closed
bomgar opened this issue Dec 15, 2023 · 2 comments · Fixed by #586
Closed

Bad contrast with neogit integration #627

bomgar opened this issue Dec 15, 2023 · 2 comments · Fixed by #586
Labels
bug Something isn't working

Comments

@bomgar
Copy link

bomgar commented Dec 15, 2023

Description

The contrast of text on active blocks (block where the cursor is) is bad.

Neovim version

NVIM v0.9.4
Build type: Release
LuaJIT 2.1.1702233742

Terminal and multiplexer

wezterm 20230712-072601-f4abf8fd

Catppuccin version / branch / rev

64dc309

Steps to reproduce

Open neogit in a git repo with changes and history. :Neogit

Expected behavior

Text should have better contrast.

Actual behavior

2023-12-15-110256_grim
2023-12-15-110248_grim

This does not happen if I set neogit = false in my catppuccin config.

The cursor position is important. If I move the cursor to somewhere else it looks good.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
    "catppuccin/nvim",
    "nvim-lua/plenary.nvim",
    {"NeogitOrg/neogit", opts={}},
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("catppuccin")

-- add anything else here
@bomgar bomgar added the bug Something isn't working label Dec 15, 2023
@rewhile
Copy link
Contributor

rewhile commented Dec 15, 2023

I believe this bug was introduced in #614

Mocha Latte

Before

image

image

After

image

image

I pushed an update, can you try it out?

@bomgar
Copy link
Author

bomgar commented Dec 15, 2023

Perfect. Thank you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants