Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bitfinex v2 OHLCV incorrect order #374

Closed
s5s opened this issue Oct 23, 2017 · 4 comments
Closed

Bitfinex v2 OHLCV incorrect order #374

s5s opened this issue Oct 23, 2017 · 4 comments
Assignees

Comments

@s5s
Copy link

s5s commented Oct 23, 2017

Hi, bitfinex2 exchange rest api unfortunately returns data in ochlv order. When I call ccxt.bitfinex2.fetch_ohlcv() I get the data in what appears to be oChlv order. My assumption is that the caller of ccxt.bitfinex2.fetch_ohlcv() should expect this function to return the data in ohlcv order in which case we have a bug in ccxt.bitfinex2.fetch_ohlcv().

@kroitor kroitor self-assigned this Oct 23, 2017
@s5s
Copy link
Author

s5s commented Oct 23, 2017

@kroitor
Copy link
Member

kroitor commented Oct 23, 2017

@s5s hi! Thanks a lot for opening this issue! I'll fix it right away. Should be there in 10 minutes.

@s5s
Copy link
Author

s5s commented Oct 23, 2017

Thanks! I would be interested in the hash of the commit that fixes it so that I can possibly submit patches for similar issues in the future. Regards

@kroitor
Copy link
Member

kroitor commented Oct 23, 2017

@s5s there it is ↑ GitHub prints it out automatically, when i reference #374 in the commit message:

https://github.com/ccxt-dev/ccxt/commit/e24e264959b162274b3d8465caf900b1de37ad72

@kroitor kroitor changed the title Bitfinex Ohlcv incorrect order Bitfinex v2 OHLCV incorrect order Oct 23, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants