Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unable to build in docker #1199

Open
qchenevier opened this issue Feb 11, 2025 · 0 comments · May be fixed by #1200
Open

Unable to build in docker #1199

qchenevier opened this issue Feb 11, 2025 · 0 comments · May be fixed by #1200

Comments

@qchenevier
Copy link

Hello,

First of all, thanks for maintaining this repository. It is very useful in my stack. Thank you for all the hard work. 🙏

When I tried to build a docker image recently, the buildInDocker script couldn't do the compilation using the latest dev version.

Here is the latest message before the compilation stops:

[ 62%] Building CXX object libs/MVS/CMakeFiles/MVS.dir/SceneReconstruct.cpp.o
/openMVS/libs/MVS/SceneReconstruct.cpp:41:10: fatal error: CGAL/AABB_traits_3.h: No such file or directory
   41 | #include <CGAL/AABB_traits_3.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Here is a minimal Dockerfile to reproduce:

FROM mambaorg/micromamba:1.5.0-jammy-cuda-11.8.0
USER root
WORKDIR /root
RUN curl https://raw.githubusercontent.com/cdcseacave/openMVS/master/docker/buildInDocker.sh \
    --output openMVS-buildInDocker.sh && \
    chmod +x openMVS-buildInDocker.sh && \
    ./openMVS-buildInDocker.sh --cuda 0 --master 0 --user_id 123456 --group_id 123456
ENV PATH /usr/local/bin/OpenMVS:$PATH

Note: It's on purpose that I don't use the cuda flag, even if it's an image containing cuda.

As of today, when the script runs, the libcgal-dev version installed is 5.4-1.

I've found a workaround by editing the libs/MVS/SceneReconstruct.cpp file:

- #include <CGAL/AABB_traits_3.h>
- #include <CGAL/AABB_triangle_primitive_3.h>
+ #include <CGAL/AABB_traits.h>
+ #include <CGAL/AABB_triangle_primitive.h>
@qchenevier qchenevier linked a pull request Feb 11, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant