From 3c13a4fda8b425123e4bf51d99f72c481b83b54a Mon Sep 17 00:00:00 2001 From: Nicolas Temciuc Date: Sat, 14 Dec 2024 08:56:38 -0300 Subject: [PATCH 1/3] ci: test against `Ruby 3.3` --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8d381f2..fc4892d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,6 +16,7 @@ jobs: fail-fast: false matrix: ruby-version: + - 3.3 - 3.2 - 3.1 - '3.0' From 93066dae83bad81593765125e19035dd56215f9b Mon Sep 17 00:00:00 2001 From: Nicolas Temciuc Date: Sat, 14 Dec 2024 08:58:24 -0300 Subject: [PATCH 2/3] ci: run `rubocop` against `Ruby 3.3` --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fc4892d..375e212 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -50,6 +50,6 @@ jobs: bundler-cache: true - name: Run rubocop run: bundle exec rubocop - if: ${{ matrix.ruby == '3.2' }} + if: ${{ matrix.ruby == '3.3' }} - name: Run tests run: bundle exec rspec From da22fec15fc12f0d0a54bb98b59732542f0320cd Mon Sep 17 00:00:00 2001 From: Nicolas Temciuc Date: Sat, 14 Dec 2024 09:04:46 -0300 Subject: [PATCH 3/3] fix(ci): correct rubocop condition for Ruby 3.3 in workflow Fixed the `if` condition that caused the `rubocop` job to not run for Ruby 3.3. The condition was incorrectly referencing `matrix.ruby` instead of `matrix.ruby-version`, resulting in the step being skipped. --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 375e212..e971f40 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -50,6 +50,6 @@ jobs: bundler-cache: true - name: Run rubocop run: bundle exec rubocop - if: ${{ matrix.ruby == '3.3' }} + if: ${{ matrix.ruby-version == '3.3' }} - name: Run tests run: bundle exec rspec