Use logging.Logger.warning #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of `logging.Logger.warn` was deprecated since Python 3.3 and it will be removed in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#logging
Nusnus
approved these changes
Jul 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
logging.Logger.warnwas deprecated since Python 3.3 and it will be removed in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#loggingThere is a pull request (#2052) with similar changes, however merging that PR will likely take time. At the same time, Fedora 41 comes with Python 3.13 and packages kombu. A similar patch can be found in https://src.fedoraproject.org/rpms/python-kombu/pull-request/10. To avoid the need for distro-specific patches (see https://pkgs.org/search/?q=python3.13 for distros that come with Python 3.13), I propose to make this change in this upstream repository.
Unfortunately, I could not find an easy way to prevent issues like this with linters: the current stable version of
mypydoes not find this issue (mypyinstalled from master can find this issue though).ruff, proposed in #2055, does not find this issue: astral-sh/ruff#12295.