Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: interpret the ssl_check_hostname as a boolean #2229

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

d9pouces
Copy link
Contributor

!close #2210

ssl_check_hostname is left as-is ("false"), and is evaluated to True when a Redis connection is created.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (def208a) to head (19c7cd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2229   +/-   ##
=======================================
  Coverage   81.50%   81.51%           
=======================================
  Files          77       77           
  Lines        9524     9526    +2     
  Branches     1152     1153    +1     
=======================================
+ Hits         7763     7765    +2     
  Misses       1569     1569           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy self-requested a review February 5, 2025 06:36
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also consider adding an integration test for this?

@d9pouces
Copy link
Contributor Author

d9pouces commented Feb 5, 2025

What would you consider as an integration test?

@auvipy
Copy link
Member

auvipy commented Feb 6, 2025

@Nusnus Nusnus marked this pull request as draft February 8, 2025 19:37
Nusnus
Nusnus previously requested changes Feb 8, 2025
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to draft until the CI fully passes

@d9pouces d9pouces marked this pull request as ready for review February 9, 2025 13:09
@auvipy auvipy dismissed Nusnus’s stale review February 12, 2025 06:47

review addressed

@auvipy auvipy added this to the 5.5.0 milestone Feb 12, 2025
@auvipy auvipy merged commit 5d95b64 into celery:main Feb 12, 2025
42 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssl_check_hostname parameter is not respected for Redis connections
3 participants