-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: interpret the ssl_check_hostname as a boolean #2229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
=======================================
Coverage 81.50% 81.51%
=======================================
Files 77 77
Lines 9524 9526 +2
Branches 1152 1153 +1
=======================================
+ Hits 7763 7765 +2
Misses 1569 1569
Partials 192 192 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also consider adding an integration test for this?
What would you consider as an integration test? |
you can take idea from here https://github.com/celery/kombu/blob/main/t/integration/test_redis.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to draft until the CI fully passes
…o bug-2210-ssl_check_hostname
!close #2210
ssl_check_hostname is left as-is ("false"), and is evaluated to True when a Redis connection is created.