Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ibctesting framework does not support multiple versions #3137

Closed
cmwaters opened this issue Feb 28, 2024 · 1 comment
Closed

ibctesting framework does not support multiple versions #3137

cmwaters opened this issue Feb 28, 2024 · 1 comment
Assignees
@ninabarbakadze
Labels
bug Something isn't working priority:normal optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related
Milestone
v2

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Feb 28, 2024 •
edited by rootulp
Loading

Summary

Discovered in #3112, github.com/cosmos/ibc-go/v6/testing doesn't support versions as it does not pass the version field to BeginBlock. The 0 app version causes the application to panic.

Proposal

Amend "github.com/cosmos/ibc-go/v6/testing" to pass the app version initiated in the InitialHeader through to the CurrentHeader
@cmwaters cmwaters added the bug Something isn't working label Feb 28, 2024
@evan-forbes evan-forbes mentioned this issue Feb 29, 2024
Merged
@rootulp rootulp added the WS: V2 ✌️ lemongrass hardfork related label Mar 1, 2024
@rootulp rootulp added this to the v2 milestone Mar 1, 2024
@ninabarbakadze ninabarbakadze self-assigned this Apr 5, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Apr 5, 2024
Merged
10 tasks
@rootulp rootulp mentioned this issue Apr 8, 2024
Closed
@rootulp rootulp added needs:triage priority:normal optional label to track the relative priority of planned items and removed needs:triage labels Apr 9, 2024
@rootulp
Copy link
Collaborator

rootulp commented Apr 26, 2024

Pretty sure this is closed by cosmos/ibc-go#6179 which was included in https://github.com/cosmos/ibc-go/releases/tag/v6.3.1 which we upgraded to in #3379

@rootulp rootulp closed this as completed Apr 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
bug Something isn't working priority:normal optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Milestone
v2
Development

No branches or pull requests
3 participants
@rootulp @cmwaters @ninabarbakadze