Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

support extra annotations on resoures in helm chart #175

Open
thesuperzapper opened this issue Sep 7, 2023 · 1 comment · May be fixed by #214
Open

support extra annotations on resoures in helm chart #175

thesuperzapper opened this issue Sep 7, 2023 · 1 comment · May be fixed by #214
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@thesuperzapper
Copy link

I would like to be able to set "global" annotations for all resources in the trust-manager helm chart.

The main purpose of this is to allow a single "combined" chart of cert-manager and trust-manager to be applied successfully using Argo CD. Right now, if a combined chart is created, the first sync will always fail (because trust-manager depends on cert-manager being ready).

However, if I could set annotations on all resources, I would be able to make use of Argo CD's Sync Waves to put all the trust-manager resources in a wave that happens after cert-manager.

For example, we might add a value called app.annotations to the chart (which adds no annotations by default), and use it like follows:

app:
  annotations:
    ## assuming cert-manager has a lower wave (or no wave) set
    argocd.argoproj.io/sync-wave: "5"
@thesuperzapper thesuperzapper linked a pull request Oct 26, 2023 that will close this issue
Open
@cert-manager-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@cert-manager-prow cert-manager-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add helm values for annotations thesuperzapper/trust-manager
2 participants
@thesuperzapper @cert-manager-bot