Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add matchExpressions to Bundle's spec.target.namespaceSelector #302

Open
sathieu opened this issue Feb 22, 2024 · 6 comments · May be fixed by #476
Open

Add matchExpressions to Bundle's spec.target.namespaceSelector #302

sathieu opened this issue Feb 22, 2024 · 6 comments · May be fixed by #476
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@sathieu
Copy link

sathieu commented Feb 22, 2024

Currently, bundle has:

spec:
  target:
    namespaceSelector:
      matchLabels:
        linkerd.io/inject: "enabled"

We need support for:

spec:
  target:
    namespaceSelector:
      matchExpressions:
      - key: kubitus-project.gitlab.io/inject-ca-bundle
        operator: NotIn
        values:
        - 'false'

Ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements
@erikgb
Copy link
Contributor

erikgb commented Feb 22, 2024

I think this was discussed in #258 - as this new feature supports all types of selectors. It would make sense to add this IMO, and I also think it could be added non-breaking. PRs welcome! 😸

@sathieu
Copy link
Author

sathieu commented Feb 22, 2024

@ocampeau Could you please take a look at this feature request 🙏?

@ocampeau
Copy link
Contributor

I think it could be a nice addition yes. This can definitely be done in a non-breaking fashion. The Kubernetes libraries already provides the types for that.

@erikgb
Copy link
Contributor

erikgb commented Jul 15, 2024

/help

@cert-manager-prow
Copy link
Contributor

@erikgb:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 15, 2024
@jsalatiel
Copy link

Any updates on this ?

@erikgb erikgb linked a pull request Nov 16, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support namespaceSelector matchExpressions erikgb/trust-manager
4 participants
@sathieu @erikgb @jsalatiel @ocampeau