Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Correct minor mistakes in 1.11 #545

Closed
JonathanGregory opened this issue Sep 18, 2024 · 1 comment
Closed

Correct minor mistakes in 1.11 #545

JonathanGregory opened this issue Sep 18, 2024 · 1 comment
Labels
change agreed Issue accepted for inclusion in the next version and closed defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Milestone
1.12

Comments

@JonathanGregory
Copy link
Contributor

JonathanGregory commented Sep 18, 2024 •
edited
Loading

I have noticed two typos in the Revision History. I have created #544 to correct them.

I suggest we might correct all minor mistakes of this magnitude by many PRs linked to this single issue. I feel it's useful to have an issue, without which a PR is not so visible in the record. Adding such small changes to the Revision History seems less than ideal, as @larsbarring remarked about the very extensive revision history of 1.11. How do others feel about this suggestion?
@JonathanGregory JonathanGregory added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Sep 18, 2024
@JonathanGregory JonathanGregory mentioned this issue Sep 18, 2024
Merged
@JonathanGregory JonathanGregory changed the title Correct minor mistakes in 1.11 Correct minor mistakes in 1.12 Sep 18, 2024
@JonathanGregory JonathanGregory changed the title Correct minor mistakes in 1.12 Correct minor mistakes in 1.11 Sep 20, 2024
@larsbarring
Copy link
Contributor

I fully agree. And as the changes are minimal I will merge the PR now.

@JonathanGregory JonathanGregory added the change agreed Issue accepted for inclusion in the next version and closed label Nov 28, 2024
@JonathanGregory JonathanGregory added this to the 1.12 milestone Nov 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
change agreed Issue accepted for inclusion in the next version and closed defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
2 participants
@JonathanGregory @larsbarring