-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
supports fullwidth characters & not specified end #29
Conversation
You need to add tests. |
…t bug out Travis CI now. Also added tests.
I am sorry I am not very capable with Travis CI ... I am fixing its issues and I will commit again. Hoping I can reclaim the bounty. Thanks @sindresorhus |
You don't need Travis to run the tests. Just run |
All done, please check it out again, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the fullwidth
dependency.
I have been busy lately, but I will do these changes asap. Thanks. |
npm ERR! Test failed. See above for more details. For some reason this stopped working when |
… a variable name for more readability.
@TiagoDanin @Qix- please check it out guys, and let me know if anything is missing, so that I may recover the bounty. Thanks :) |
I just noticed that there are two PR solving the same thing. #27 was opened a month before this one, so that's the one I'm going with. |
@sindresorhus |
But as commented later on, that’s not a bug. We intentionally do not support that. If that should change, it should be discussed in an issue first. |
Might need some cost-efficiency evaluation to be done. Also, I suggest one of the following libraries to be considered for future revisions:
This, of course, seeing how they are taking into account ISO standards relating to special characters readability and usability. Hope it works now.
P.S.: I looked at the previously cancelled pull, and made sure the tests complied. Hope it works.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor