Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhance CheckableAvatar component to behave as an actual Checkbox #1237

Closed
sungik-choi opened this issue Mar 24, 2023 · 0 comments · Fixed by #1320
Closed

Enhance CheckableAvatar component to behave as an actual Checkbox #1237

sungik-choi opened this issue Mar 24, 2023 · 0 comments · Fixed by #1320
Assignees
Labels
a11y Issue or PR related to accessibility enhancement Issues or PR related to making existing features better #reimplementation Issue or PR related to Reimplementation of existing components (#1105)

Comments

@sungik-choi
Copy link
Contributor

sungik-choi commented Mar 24, 2023

Description

CheckableAvatar 컴포넌트가 실제 체크박스처럼 동작하도록 개선합니다.

Reasons for suggestion

현재 CheckableAvatar 는 HTMLDivElement 로 인터랙션이 불가능한 엘리먼트로 구현되어있습니다. 실제로는 체크박스처럼 동작하기 때문에 내부 구현도 그에 알맞게 개선되면 좋겠습니다.

Proposed solution

  • 실제 Checkbox의 의미를 갖도록 변경합니다.
    • 키보드 포커스가 가능해야 합니다. 포커스 디자인이 마찬가지로 추가되면 좋겠습니다.
    • Space 키를 통해 체크가 가능해야합니다.
    • HTMLFormElement 와 실제 Form 요소로서 함께 사용할 수 있어야합니다.
  • Avatar 의 name 등, 대표할 수 있는 텍스트가 VisuallyHidden 처리된 라벨로 컴포넌트 내부에 포함되어 스크린 리더 사용자들에게 더 풍부한 정보를 제공할 수 있으면 좋겠습니다.
  • 인터페이스가 Checkbox 컴포넌트와 통일되면 좋겠습니다.
    • isChecked -> checked
    • isCheckable 도 비슷하게 checkable 로 변경되는 편이 예측 가능성을 높일 수 있어 좋을 거 같습니다.
    • 체크가 가능한 컴포넌트에 대한 공용 인터페이스를 선언하고, 재사용하는 방식이 장기적으로 가장 좋아보입니다.

References

@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better a11y Issue or PR related to accessibility labels Mar 24, 2023
@sungik-choi sungik-choi self-assigned this Apr 3, 2023
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Apr 3, 2023
@sungik-choi sungik-choi moved this from 📌 Backlog to 📆 This Week in Bezier React Apr 3, 2023
@sungik-choi sungik-choi added the #reimplementation Issue or PR related to Reimplementation of existing components (#1105) label Apr 3, 2023
@sungik-choi sungik-choi moved this to 🏃‍♀️ In progress in Bezier React Apr 7, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to ✅ Done in Bezier React May 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
a11y Issue or PR related to accessibility enhancement Issues or PR related to making existing features better #reimplementation Issue or PR related to Reimplementation of existing components (#1105)
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant