Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convert components to strongly typed polymorphic component #906

Open
Dogdriip opened this issue Aug 1, 2022 · 2 comments
Open

Convert components to strongly typed polymorphic component #906

Dogdriip opened this issue Aug 1, 2022 · 2 comments
Assignees
@Dogdriip
Labels
enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes

Comments

@Dogdriip
Copy link
Contributor

Dogdriip commented Aug 1, 2022

Description

강타입 Polymorphic component를 위한 타입들을 정의하고, bezier-react의 컴포넌트에 이를 적용합니다.

Reasons for suggestion

WIP

Proposed solution

References
@Dogdriip Dogdriip added the status:need triage Issue or PR that need triage attention label Aug 1, 2022
@Dogdriip Dogdriip self-assigned this Aug 1, 2022
@Dogdriip Dogdriip added enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes and removed status:need triage Issue or PR that need triage attention labels Aug 1, 2022
@Dogdriip Dogdriip mentioned this issue Aug 1, 2022
Closed
9 tasks
@Dogdriip
Copy link
Contributor Author

Dogdriip commented Sep 7, 2022

microsoft/TypeScript#49707 TypeScript 4.8 이후로 as prop 등에 대한 Contextual typing이 개선됩니다. 이 이슈에도 영향이 있을 것 같고, 조금 더 수월하게 Polymorphic component에 대한 타이핑이 가능해 보입니다.

@sungik-choi sungik-choi moved this to Q4 2022 in Bezier React Nov 9, 2022
@sungik-choi sungik-choi mentioned this issue Nov 9, 2022
Closed
@sungik-choi sungik-choi moved this from Q4 2022 to Q1 2023 in Bezier React Dec 22, 2022
@sungik-choi sungik-choi moved this from 🏃‍♀️ In progress to 📌 Backlog in Bezier React Jan 17, 2023
@sungik-choi sungik-choi added the priority:A Issue that important and urgent label Jun 21, 2023
@sungik-choi sungik-choi mentioned this issue Jun 21, 2023
Closed
@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi removed the priority:A Issue that important and urgent label Dec 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Dogdriip Dogdriip

Labels
enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes
Projects
No open projects
Bezier React
Status: 📌 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dogdriip @sungik-choi