Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: concat two list of strings then turn it into set #674

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

naihsuanshao
Copy link
Contributor

Summary

To fix this error

Error: Too many function arguments
│ 
│   on .terraform/modules/biohub-s3-readonly/aws-iam-role-s3-readonly/main.tf line 55, in data "aws_iam_policy_document" "s3-bucket-readonly":
│   55:     resources = toset(formatlist("arn:aws:s3:::%s", var.s3_bucket_names), formatlist("arn:aws:s3:::%s/*", var.s3_bucket_names))
│     ├────────────────
│     │ while calling toset(v)
│     │ var.s3_bucket_names is a set of string
│ 
│ Function "toset" expects only 1 argument(s).

Test Plan

Say unittests, or list out steps to verify changes.

References

(Optional) Additional links to provide more context.

@naihsuanshao naihsuanshao requested a review from a team as a code owner October 31, 2024 23:44
@naihsuanshao naihsuanshao requested review from hspitzley-czi and kuannie1 and removed request for hspitzley-czi October 31, 2024 23:44
Copy link
Contributor

@kuannie1 kuannie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@kuannie1 kuannie1 merged commit 8cd5290 into main Nov 1, 2024
108 checks passed
@kuannie1 kuannie1 deleted the nshao/change-set-to-concat branch November 1, 2024 21:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants