Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convert Scale Legacy Callbacks to Plugin Hooks #10155

Open
etimberg opened this issue Feb 13, 2022 · 0 comments · May be fixed by #10631
Open

Convert Scale Legacy Callbacks to Plugin Hooks #10155

etimberg opened this issue Feb 13, 2022 · 0 comments · May be fixed by #10631
Labels
breaking change type: enhancement
Milestone
Version 5.0.0

Comments

@etimberg
Copy link
Member

Feature Proposal

There are a number of legacy callbacks in scales that should either be removed or replaced with plugin hooks.

Legacy callbacks:

  • beforeUpdate
  • beforeSetDimensions
  • afterSetDimensions
  • beforeTickToLabelConversion
  • afterTickToLabelConversion
  • beforeCalculateLabelRotation
  • afterCalculateLabelRotation
  • beforeFit
  • afterFit
  • afterUpdate

Possible Implementation

Replace direct call(this.options[plugin]) with Scale._callHooks() as we've already done for beforeDataLimits, afterDataLimits, beforeBuildTicks, afterBuildTicks
@etimberg etimberg added this to the Version 4.0 milestone Feb 13, 2022
@LeeLenaleee LeeLenaleee linked a pull request Aug 25, 2022 that will close this issue
Draft
4 tasks
@etimberg etimberg modified the milestones: Version 4.0, Version 5.0 Oct 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
breaking change type: enhancement
Projects
None yet
Milestone
Version 5.0.0
Development

Successfully merging a pull request may close this issue.

Start moving lecacy scale hooks to plugin LeeLenaleee/Chart.js
1 participant
@etimberg