Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cmdeploy run should refuse to run if iroh subdomain isn't set #447

Closed
missytake opened this issue Oct 31, 2024 · 1 comment · Fixed by #448
Closed

cmdeploy run should refuse to run if iroh subdomain isn't set #447

missytake opened this issue Oct 31, 2024 · 1 comment · Fixed by #448

Comments

@missytake
Copy link
Contributor

  • expected behavior: instead of failing at the acmetool step which could affect the letsencrypt rate limit, if I have a necessary subdomain like iroh.$mail_domain not set, it should refuse to run.
  • actual behavior: it just runs. actually not even cmdeploy dns warns us about the missing subdomain atm.
@missytake
Copy link
Contributor Author

Ah, we have set iroh_relay in chatmail.ini, that's why it didn't refuse to run. The better solution is to not try to get a cert in this case.

@missytake missytake mentioned this issue Oct 31, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acmetool: only ask for iroh.$mail_domain cert if iroh_relay isn't set chatmail/server
1 participant
@missytake