-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
create mrz correction #29
Conversation
Codecov ReportBase: 85.32% // Head: 87.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 85.32% 87.83% +2.50%
==========================================
Files 38 40 +2
Lines 327 378 +51
Branches 82 95 +13
==========================================
+ Hits 279 332 +53
+ Misses 48 46 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@targos In the issue I asked:
But it was implemented as separate files like 'td1Correction'. I think this implementation is more difficult to maintain but maybe I missed something. |
I agree. |
I refactored the code (correct each field before parsing), but there is one issue in the autocorrect I see that the solution is to correct all the line then start to parse fields |
Sounds good to me. A first loop could create the initial "empty" detail object for each field and do the correction. Then another pass is done to parse. |
Implemented. |
closes #22