Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Saving and loading (fixpoint) filters #239

Closed
3 tasks done
chipmuenk opened this issue Sep 14, 2023 · 2 comments
Closed
3 tasks done

Saving and loading (fixpoint) filters #239

chipmuenk opened this issue Sep 14, 2023 · 2 comments

Comments

@chipmuenk
Copy link
Owner

chipmuenk commented Sep 14, 2023

Several problems exist when saving / loading filters:

  • : When saving filters, it seems as if coefficients are only saved with an accuracy of 8 digits. This would be due to pyfda_io_lib.save_data_np() and its default option fmt=%f.

  • : When reading back a fixpoint filter, selecting the b,a tab can crash the software with

      File "d:\daten\design\python\git\pyfda\pyfda\input_widgets\input_coeffs.py", line 548, in _refresh_table_item
        if self.ba_q[col + 2][row] > 0:
      TypeError: 'int' object is not subscriptable
    

    This can be avoided by running a fixpoint simulation, but it seems the ba_q[][] array is not loaded / updated / created. Coefficient formats between the fixpoint tab and b,a can also be out of sync.

  • : The key fb.fil[0]['fxqc']['QCB']['fx_base'] is not present in older filter designs, causing KeyErrors and an empty coefficient table. The import routine is not robust enough, there should be a default fallback.

@ksrp1984
Copy link

Version 0.8.3. The program doesn't crash when I click "Save" with fixed point coefficients. But the coefficients are not saved. Nothing happens

@chipmuenk
Copy link
Owner Author

Fix will be contained in v0.9.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants