Make Queue.irrevocable work properly in chisel3 #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardcwang
added
DO NOT MERGE
Bugfix
edwardcwang
force-pushed
the
queue3
branch
3 times, most recently
from
7d33860 to
375e229
Compare
|
This is ready for review. |
Closed
seldridge
requested changes
Aug 11, 2019
There was a problem hiding this comment.
Looks good. We really need full coverage of all methods/classes and this helps!
I think the test can be pared down to strictly test elaboration. There's likely no need to do a full-blown Verilator run here, considering an irrevocable queue is just a shim around a queue returning a different interface. I provided one example of how I would do this as a suggestion.
|
|
|
@seldridge Fixed after a long delay ;) |
seldridge
approved these changes
Feb 10, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1134
Type of change: bugfix
Impact: no functional change
Development Phase: implementation
Release Notes: Fix unexpected error from attempting to use Queue.irrevocable in chisel3.