Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Retain default version assignment #1365

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Feb 28, 2020

The release process uses python to scan and set expected versions for a release. The val defaultVersions = stanza should be present for this to work.

Impact: no functional change

Development Phase: implementation

Release Notes
Restore the defaultVersions map to facilitate release generation and testing.

The release process uses python to scan and set expected versions for a release. The `val defaultVersions = ` stanza should be present for this to work.
@ucbjrl ucbjrl added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Feb 28, 2020
@ucbjrl ucbjrl added this to the 3.3.0 milestone Feb 28, 2020
@ucbjrl ucbjrl requested a review from edwardcwang February 28, 2020 17:10
@ucbjrl ucbjrl requested a review from a team as a code owner February 28, 2020 17:10
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little out of my league but looks good to me.

@mergify mergify bot merged commit 0169392 into master Feb 28, 2020
@ucbjrl ucbjrl deleted the restore_release_and_testing_stanzas branch April 10, 2020 16:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants