Remove toNamed (and friends) deprecation. #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As with the firrtl version of this PR, I've left the old deprecation warnings as comments, but bumped the affected versions. |
jackkoenig
reviewed
Mar 13, 2020
| @@ -258,7 +258,7 @@ package experimental { | |||
| * | |||
| * @note Should not be called until circuit elaboration is complete | |||
| */ | |||
| @deprecated("toNamed API is deprecated -- use toTarget instead", "3.2") | |||
| //@deprecated(toNamed API is deprecated -- use toTarget instead", "3.3") | |||
There was a problem hiding this comment.
Did you mean to delete the leading double quotes?
There was a problem hiding this comment.
Nope. Faulty regex. Thanks @jackkoenig.
jackkoenig
approved these changes
Mar 13, 2020
ucbjrl
added
the
Please Merge
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: chipsalliance/firrtl#1449
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Remove the deprecation of
Nameduntil we have time to sort out the issues with de-duplication ofTargets