Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove toNamed (and friends) deprecation. #1377

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Remove toNamed (and friends) deprecation. #1377

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f0b89a
Remove toNamed (and friends) deprecation.
ucbjrl Mar 13, 2020
845b3a4
Add inadvertently deleted leading double quote.
ucbjrl Mar 13, 2020
951cf57
Remove commented out deprecations.
ucbjrl Mar 17, 2020
d063bcb
Merge branch 'master' into undeprecate_Named
ucbjrl Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chiselFrontend/src/main/scala/chisel3/Module.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ package experimental {
*
* @note Should not be called until circuit elaboration is complete
*/
@deprecated("toNamed API is deprecated -- use toTarget instead", "3.2")
//@deprecated(toNamed API is deprecated -- use toTarget instead", "3.3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete the leading double quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Faulty regex. Thanks @jackkoenig.

final def toNamed: ModuleName = toTarget.toNamed

/** Returns a FIRRTL ModuleTarget that references this object
Expand Down
4 changes: 2 additions & 2 deletions chiselFrontend/src/main/scala/chisel3/internal/Builder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ trait InstanceId {
def parentPathName: String
def parentModName: String
/** Returns a FIRRTL Named that refers to this object in the elaborated hardware graph */
@deprecated("toNamed API is deprecated -- use toTarget instead", "3.2")
//@deprecated(toNamed API is deprecated -- use toTarget instead", "3.3")
def toNamed: Named
/** Returns a FIRRTL IsMember that refers to this object in the elaborated hardware graph */
def toTarget: IsMember
Expand Down Expand Up @@ -169,7 +169,7 @@ private[chisel3] trait NamedComponent extends HasId {
/** Returns a FIRRTL ComponentName that references this object
* @note Should not be called until circuit elaboration is complete
*/
@deprecated("toNamed API is deprecated -- use toTarget instead", "3.2")
//@deprecated(toNamed API is deprecated -- use toTarget instead", "3.3")
final def toNamed: ComponentName =
ComponentName(this.instanceName, ModuleName(this.parentModName, CircuitName(this.circuitName)))

Expand Down