Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove ChiselLegacyAnnotation #1544

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

jackkoenig
Copy link
Contributor

It was private and unused

There is no impact on any user code. This also enables chipsalliance/firrtl#1833 to pass CI.

Related issue:

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

It was private and unused
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jackkoenig jackkoenig merged commit f103ce0 into master Aug 10, 2020
@seldridge seldridge added this to the 3.4.0 milestone Aug 13, 2020
@jackkoenig jackkoenig deleted the remove-firrtl-legacy-annotation branch September 16, 2020 17:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants