-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix broken links in docs #1643
Fix broken links in docs #1643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a fix. The links don't seem to work within the GitHub interface (missing the .md extension), but I assume this is generating to some other target?
Ugh. If it has the .md interface, then the website is broken. If it doesn't, then the github interface is broken.... Perhaps I need to spend more time figuring this out. |
Ok for now its better to break github than the website, so i'll merge and try and find a permanent fix later. |
(cherry picked from commit 362a3e3)
* Add attributes, ifdefs to emitter. * Make ifdef API a little cleaner. * Remove references to ifdefs. * Remove more of the ifdef stuff I missed * Fix up failing tests * Add multiple attribute test case * Remove tpe as a parameter from Annotations. Some general refactoring. * Add some documentation. * Incorporate some feedback * Expand some spaghetti code, add comments * Fix type signature by removing it * bug fix in test * Fix unchecked type parameter matches in AddDescriptionNodes. * use target to replace name Co-authored-by: Paul Rigge <rigge@berkeley.edu> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Contributor Checklist
Type of Improvement
Reviewer Checklist (only modified by reviewer)
Please Merge
?