Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix some typo and using foreach instead of map in BoringUtils #1755

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix some typo and using foreach instead of map in BoringUtils #1755

merged 2 commits into from
Jan 27, 2021

Conversation

Soya-Onishi
Copy link

This commit does what title says.

It is prefer to use foreach instead of map when lambda returns Unit if there are no specific reasons.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code refactoring

API Impact

none

Backend Code Generation Impact

none

Desired Merge Strategy

Squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Fix some typo and using foreach instead of map in BoringUtils
e673471 
If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.
@jackkoenig jackkoenig added this to the 3.2.x milestone Jan 27, 2021
jackkoenig
jackkoenig approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better docs and more clear code is always a win! Thanks!

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 27, 2021
@mergify mergify bot merged commit 654db98 into chipsalliance:master Jan 27, 2021
mergify bot pushed a commit that referenced this pull request Jan 27, 2021
Fix some typo and using foreach instead of map in BoringUtils (#1755)
86d11fa 
If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 654db98)
@mergify mergify bot mentioned this pull request Jan 27, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jan 27, 2021
Fix some typo and using foreach instead of map in BoringUtils (#1755)
78ca65c 
If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 654db98)
@mergify mergify bot mentioned this pull request Jan 27, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jan 27, 2021
Fix some typo and using foreach instead of map in BoringUtils (#1755)
8a2a641 
If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 654db98)
@mergify mergify bot mentioned this pull request Jan 27, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Jan 27, 2021
mergify bot added a commit that referenced this pull request Jan 27, 2021
@mergify
Fix some typo and using foreach instead of map in BoringUtils (#1755) (…
73d4000 
…#1760)

If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 654db98)

Co-authored-by: SoyaOhnishi <ohnishi.soya@arc.cs.okayama-u.ac.jp>
mergify bot added a commit that referenced this pull request Jan 27, 2021
@mergify
Fix some typo and using foreach instead of map in BoringUtils (#1755) (…
a9002b0 
…#1761)

If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 654db98)

Co-authored-by: SoyaOhnishi <ohnishi.soya@arc.cs.okayama-u.ac.jp>
mergify bot added a commit that referenced this pull request Jan 27, 2021
@mergify
Fix some typo and using foreach instead of map in BoringUtils (#1755) (…
80bd661 
…#1762)

If a method passed to higher function does not return any value,
it is prefer to use `foreach` instead of `map`.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 654db98)

Co-authored-by: SoyaOhnishi <ohnishi.soya@arc.cs.okayama-u.ac.jp>
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Soya-Onishi @jackkoenig