Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump to Scala 2.12.13 #1766

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Bump to Scala 2.12.13 #1766

merged 1 commit into from
Feb 1, 2021

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [NA] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

This allows users of the Chisel plugin to use Scala 2.12.13 (plugins require publishing for each minor version)

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Bump to Scala 2.12.13, publish chisel3-plugin for 2.12.13.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.4.x milestone Feb 1, 2021
@jackkoenig jackkoenig requested review from chick and azidar February 1, 2021 18:39
@jackkoenig
Copy link
Contributor Author

As this modifies the testing workflow, it will require manual backporting.

@jackkoenig jackkoenig merged commit 445b5ce into master Feb 1, 2021
@mergify mergify bot added the Backported This PR has been backported label Feb 1, 2021
jackkoenig added a commit that referenced this pull request Feb 1, 2021
(cherry picked from commit 445b5ce)
jackkoenig added a commit that referenced this pull request Feb 1, 2021
* Bump to Scala 2.12.13 (#1766)

(cherry picked from commit 445b5ce)

* Fix chisel3-plugin binary compatibility checking

chisel3-plugin not yet published for Scala 2.12.13, check binary
compatibility with Scala 2.12.12 instead.
@jackkoenig jackkoenig deleted the scala-2.12.13 branch February 5, 2021 03:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backported This PR has been backported release issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants