Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Aggregate: fix typo #1789

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Aggregate: fix typo #1789

merged 1 commit into from
Feb 24, 2021

Conversation

edwardcwang
Copy link
Contributor

Not a Pokémon

Type of Improvement

documentation

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

Squash

Release Notes

Fix a typo in the Record example.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@edwardcwang
Aggregate: fix typo
bb30c3c 
Not a Pokémon
@edwardcwang edwardcwang added code improvement Squash and merge These commits don't matter, squash and merge usability labels Feb 24, 2021
albert-magyar
albert-magyar approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@albert-magyar albert-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albert-magyar albert-magyar modified the milestones: 3.5.0, 3.3.x Feb 24, 2021
@albert-magyar
Copy link
Contributor

Looks like this can cleanly backport back to 3.3.x.

@seldridge seldridge added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Feb 24, 2021
@mergify mergify bot merged commit c2ba409 into master Feb 24, 2021
mergify bot pushed a commit that referenced this pull request Feb 24, 2021
@edwardcwang
Aggregate: fix typo (#1789)
4720c5c 
Not a Pokémon

(cherry picked from commit c2ba409)
@mergify mergify bot mentioned this pull request Feb 24, 2021
Merged
mergify bot pushed a commit that referenced this pull request Feb 24, 2021
@edwardcwang
Aggregate: fix typo (#1789)
c598f06 
Not a Pokémon

(cherry picked from commit c2ba409)
@mergify mergify bot mentioned this pull request Feb 24, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Feb 24, 2021
mergify bot added a commit that referenced this pull request Feb 24, 2021
@mergify @edwardcwang
Aggregate: fix typo (#1789) (#1791)
35bfc94 
Not a Pokémon

(cherry picked from commit c2ba409)

Co-authored-by: edwardcwang <edwardcwang@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Feb 24, 2021
@mergify @edwardcwang
Aggregate: fix typo (#1789) (#1790)
a8fb10d 
Not a Pokémon

(cherry picked from commit c2ba409)

Co-authored-by: edwardcwang <edwardcwang@users.noreply.github.com>
@jackkoenig jackkoenig deleted the mew branch July 7, 2021 03:44
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@scala-steward
Update commons-text to 1.9 (#1789)
cfd1cf7
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@albert-magyar albert-magyar albert-magyar approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported code improvement Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. Squash and merge These commits don't matter, squash and merge usability
Projects
None yet
Milestone
3.3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardcwang @albert-magyar @seldridge