Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in the README is a sum, not an average.
h/t @soronpo and @BracketMaster for discussions on Gitter: https://gitter.im/freechipsproject/chisel3?at=60f4adc0ec10653d5a49fe18, also discussed in dev: #2049
I thought about making it average over 4 cycles and using a right-shift to do a proper divide, but the purpose of the example is leading into the generalized FIR filter that follows so I kept it the same and just renamed it.
Marked 3.4.x so this change is reflected on the website.
Contributor Checklist
docs/src
?Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
Please Merge
?