Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[docs] Add example of stripping directions from type #2074

Merged
merged 4 commits into from
Aug 17, 2021
Merged

[docs] Add example of stripping directions from type #2074

merged 4 commits into from
Aug 17, 2021

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Aug 16, 2021 •
edited by mwachs5
Loading

This question came up on gitter: https://gitter.im/freechipsproject/chisel3?at=6117c83e7555e333510edb83

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.4.x milestone Aug 16, 2021
@jackkoenig jackkoenig requested a review from mwachs5 August 16, 2021 21:37
jackkoenig and others added 2 commits August 17, 2021 10:27
@jackkoenig @mwachs5
Apply suggestions from code review
742479e 
Co-authored-by: Megan Wachs <megan@sifive.com>
@jackkoenig
Improve := comment
ddc6653
@jackkoenig
Copy link
Contributor Author

@mwachs5 I accepted your suggestions and tried to improve the comment for the :=

@mwachs5 mwachs5 added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Aug 17, 2021
@mergify mergify bot merged commit e14bcb1 into master Aug 17, 2021
mergify bot pushed a commit that referenced this pull request Aug 17, 2021
@jackkoenig
[docs] Add example of stripping directions from type (#2074)
3047bf5 
* [docs] Add example of stripping directions from type

* Apply suggestions from code review

Co-authored-by: Megan Wachs <megan@sifive.com>

* Improve := comment

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e14bcb1)
@mergify mergify bot mentioned this pull request Aug 17, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Aug 17, 2021
@jackkoenig jackkoenig deleted the strip-directions-cookbook branch August 17, 2021 21:28
mergify bot added a commit that referenced this pull request Aug 17, 2021
@mergify @jackkoenig
[docs] Add example of stripping directions from type (#2074) (#2078)
4c873b7 
* [docs] Add example of stripping directions from type

* Apply suggestions from code review

Co-authored-by: Megan Wachs <megan@sifive.com>

* Improve := comment

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e14bcb1)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @mwachs5