-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert Vec dynamic index with a literal to static index #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66e9a7a
to
fd3eeb1
Compare
azidar
approved these changes
Jun 1, 2023
jackkoenig
commented
Jun 1, 2023
Comment on lines
301
to
304
if (p.isLit) { | ||
return this.apply(p.litValue.intValue) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aswaterman has reminded me that we actually support out-of-bounds indices currently which means this could cause some currently working code to become an error. I'm going to change this to not accidentally change semantics and open a separate PR making those out-of-bounds indices a warning à la #3033.
fd3eeb1
to
4a68cdf
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit e20a038)
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit e20a038)
This was referenced Jun 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Backported
This PR has been backported
Performance
Improves performance, will be included in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of work that both Chisel and firtool have to do.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x
or3.6.x
depending on impact, API modification or big change:5.0.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.