-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
a Pure LLVM Lit test framework #3596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71c560d
to
a7ddc41
Compare
27fba4b
to
8ead846
Compare
14 tasks
48898b8
to
e677b52
Compare
e677b52
to
b6a7128
Compare
b6a7128
to
829bf26
Compare
399523f
to
88322c8
Compare
This PR is blocked by the scala-cli bug: VirtusLab/scala-cli#2621 |
4908724
to
29557de
Compare
29557de
to
ee93a61
Compare
After NixOS/nixpkgs#281556 merged, I can remove the vended
I'm going to slip this PR into the main branch and skip review, since it only affect the test code. The panama binding framework will use this as its test infrastructure and CI can use https://github.com/jackkoenig/FileCheck in the future. |
5752893
to
31a346f
Compare
31a346f
to
63a8013
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna use #3596 to subsume #3410, see this simple test:
In the build system, it will be processed into:
I know this is magic...
But I think this maybe the simplest way to add test and being able to migrate most of tests to this framework to share test for firtool and binding frameworks.
Farewell ScalaTest.
One possible test speed downgrade is for each RUN, it will spwan and JVM, but we have no other way to avoid this. but one of the benefit is we can control each javac and scalac option in a fine-grand way, providing a better way to increase the coverage and flexibility.
I'm thinking using LLVM LIT to replace mill execution, but not quite sure if this is a good approach, since mill can provide a prefect run cache(we can cache
out
folder in the future)Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x
,3.6.x
, or5.x
depending on impact, API modification or big change:6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.