Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement FirtoolOptions for PanamaBinding #3773

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

sequencer
Copy link
Member

  • Implement a simple data structure for FirtoolOptions
  • use it in panamalib

@sequencer sequencer requested a review from SpriteOvO January 28, 2024 14:38
@sequencer sequencer force-pushed the firtool-capi-config branch from bb4efaa to 31b4b53 Compare January 28, 2024 14:49
@sequencer sequencer added Panama Related to Panama Binding Framework Internal Internal change, does not affect users, will be included in release notes labels Jan 28, 2024
@sequencer sequencer force-pushed the firtool-capi-config branch from 31b4b53 to c9c56ad Compare January 28, 2024 14:56
Copy link
Member

@SpriteOvO SpriteOvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Implement a simple data structure for FirtoolOptions
- use it in panamalib
- move panamaCIRCT out from converter
@sequencer sequencer force-pushed the firtool-capi-config branch from ff7c76a to 3537227 Compare January 28, 2024 19:44
@sequencer sequencer merged commit 795cb15 into main Feb 2, 2024
14 checks passed
@sequencer sequencer deleted the firtool-capi-config branch February 2, 2024 03:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Internal Internal change, does not affect users, will be included in release notes Panama Related to Panama Binding Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants